Date: Tue, 28 Mar 2000 17:06:40 -0600 From: Ade Lovett <ade@lovett.com> To: Mikhail Teterin <mi@aldan.algebra.com> Cc: freebsd-ports@FreeBSD.org Subject: Re: ports/12739: New port: AT&T's DjVu Netscape plug-in Message-ID: <20000328170640.M69223@lovett.com> In-Reply-To: <200003282240.OAA80019@freefall.freebsd.org>; from mi@aldan.algebra.com on Tue, Mar 28, 2000 at 02:40:07PM -0800 References: <200003282240.OAA80019@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 28, 2000 at 02:40:07PM -0800, Mikhail Teterin wrote: > The newer version of the plugin port is at > http://virtual-estates.net/djvu-plugin.shar Unfortunately, there seem to be a couple of issues here. First, there are a number of portlint problems.. in particular the "@cwd /" in the PLIST is scary .. I think I'd want to rewrite things so MOZILLA_HOME is a relative path, based on ${PREFIX}/${LOCALBASE} -- I'd strongly recommend installing devel/portlint and using it to clean things up before submission. Second, the post-install target, rather than having a bunch of commented-out "read this", should actually display the license and have the end-user accept it. You're almost certainly breaking the terms of the license without doing this. -aDe -- Ade Lovett, Austin, TX. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000328170640.M69223>