Date: Tue, 23 May 2000 12:24:29 +0200 From: Martin Cracauer <cracauer@cons.org> To: "Andrey A. Chernov" <ache@FreeBSD.ORG> Cc: Kris Kennaway <kris@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: ports/shells/bash2 Makefile ports/shells/bash2/files md5 ports/shells/bash2/patches patch-ab patch-ac patch-ad patch-ae patch-af Message-ID: <20000523122429.A36447@cons.org> In-Reply-To: <20000507165758.A81840@freebsd.org>; from ache@FreeBSD.ORG on Sun, May 07, 2000 at 04:57:58PM -0700 References: <200005072033.NAA29021@freefall.freebsd.org> <Pine.BSF.4.21.0005071518240.38184-100000@freefall.freebsd.org> <20000507165758.A81840@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In <20000507165758.A81840@freebsd.org>, Andrey A. Chernov wrote: > On Sun, May 07, 2000 at 03:18:47PM -0700, Kris Kennaway wrote: > > On Sun, 7 May 2000, Andrey A. Chernov wrote: > > > > > Upgrade to 2.04 > > > failglob patch removed - this sort of patches must be submitted to bash > > > maintainer > > > > Hmm, isn't that your job as the port maintainer? > > I not write this patch so knows absolutely nothing about it excepting the > fact that it is applied to v2.04 with patch errors. Quick examinations not > gives me a clue why it is neccesary, I found that it is enhancement rather > then porting effort. Patches must be submitted to software maintainer by > people who really wrote them or understand them well. The failglob variable has been submitted to Chet Ramey (the bash maintainer) and is accepted for new bash versions. Before adding this to the FreeBSD port (until the official one is released), I asked you by personal mail and the freebsd-port mailing list. Noone objected and you did not respond (although you are listed as maintainer of the port). As the very least you could have checked back with me before just dropping it (even without knowing what it does, as you admint above). Now we send our users through an additional round of removed and added feature. You also silently removed static linking from the port. We once had an intensive discussion (with John Dyson) about which parts of the system should be linked statically and which not and we went ahead and linked all shells statically. I also plan to change the port to link static again. Martin -- %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Martin Cracauer <cracauer@cons.org> http://www.cons.org/cracauer/ BSD User Group Hamburg, Germany http://www.bsdhh.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000523122429.A36447>