Date: Fri, 16 Jun 2000 14:33:46 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Luoqi Chen <luoqi@watermarkgroup.com> Cc: current@FreeBSD.ORG Subject: Re: HEADSUP: bioops patch. Message-ID: <27867.961158826@critter.freebsd.dk> In-Reply-To: Your message of "Fri, 16 Jun 2000 08:27:28 EDT." <200006161227.e5GCRSd01893@lor.watermarkgroup.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200006161227.e5GCRSd01893@lor.watermarkgroup.com>, Luoqi Chen write s: >> Background: >> Ideally struct buf should have had a real OO like operations vector >> like vnodes have it, and struct bioops is the first step towards that. >> >struct buf will eventually become merely an iocmd structure, so why do >we want to complicate things here? No, struct buf will remain the cache-handle. the iocmd is called struct bio. >We already have an OO method for bwrite: VOP_BWRITE(), the problem >is most of the code are still calling bwrite() directly. Will it >solve your problem if we change every bwrite() into a VOP_BWRITE()? Well, I'm not sure it is correct to go the detour around Vnodes, if we do, we need to add VOP_BAWRITE, VOP_BDWRITE and all those other operations as well. But what vnode would you use for a buffer associated with a freeblock bitmap ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD coreteam member | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?27867.961158826>