Date: Thu, 14 Sep 2000 20:54:43 -0600 From: Warner Losh <imp@village.org> To: MIHIRA Sanpei Yoshiro <sanpei@sanpei.org> Cc: ps@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ed if_ed.c if_ed_pccard.c if_edvar.h Message-ID: <200009150254.UAA02030@harmony.village.org> In-Reply-To: Your message of "Fri, 15 Sep 2000 11:32:23 %2B0900." <200009150232.e8F2WOG03687@lavender.sanpei.org> References: <200009150232.e8F2WOG03687@lavender.sanpei.org> <200009121103.EAA90163@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200009150232.e8F2WOG03687@lavender.sanpei.org> MIHIRA Sanpei Yoshiro writes: : Arai-san suggest at bsd-nomads mailing list that we need Linksys : or not flags(and set in /etc/defaults/pccard.conf). I think so too. This might be a good very short term fix. However, I think the problem is larger than that. Before I get into that I do have one question about the ed_pccard_probe routine. I see that when the AX flag is true, we go through all the stuff to setup the AX and then call ed_probe_Novell and the rest anyway. Why is that? It seems wrong to me somehow. Back to the bigger picture. I think we need to separate out each of the "oddball" cards into their own driver. We need a Novell driver (ne), a Wester Digital driver (we) and a linksys driver (ls). Hmmm, looking at if_ed_pccard.c's probe routine it looks like we also need a AX88190 driver as well (we'd likely need to call it ae since ax(4) is already taken). These drivers would be simple front ends to the meat of the ed driver. The number of "problem child" cases in the probe routines is getting out of hand. There is also the fa-410 card by netgear (I think) that is a ne2000 card, but with what appears to be a mii bus tacked on the back. And that's just the pccard side of things, on the isa we have 3com, novel, wd, and hp as special cases. In pci land we do probing for ne2000 in the pci attach routine. I think that it may be time for a reorg. NetBSD broke up their Ed driver for these reasons, and I'm starting to see the wisdom of that approach. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200009150254.UAA02030>