Date: Sat, 16 Dec 2000 01:20:54 +0000 From: Ian Dowse <iedowse@maths.tcd.ie> To: Alfred Perlstein <bright@wintelcom.net> Cc: Matt Dillon <dillon@earth.backplane.com>, David Malone <dwmalone@maths.tcd.ie>, John Baldwin <jhb@FreeBSD.org>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sbin/fsck_ffs fsck.h main.c pass1.c pass1b.c Message-ID: <200012160120.aa45069@salmon.maths.tcd.ie> In-Reply-To: Your message of "Fri, 15 Dec 2000 15:00:17 PST." <20001215150016.L19572@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20001215150016.L19572@fw.wintelcom.net>, Alfred Perlstein writes: >* Matt Dillon <dillon@earth.backplane.com> [001215 14:51] wrote: >> I don't have time... someone make sure those patches don't do silly thing >s >> like 'printf' from a signal handler, or one of your ^T's may corrupt your >> disks. > >Doesn't look like it does. It just sets a flag that the main loops >check and reset to 0. Yes, the signal handler is as simple as possible to avoid such problems: void infohandler(sig) int sig; { got_siginfo = 1; } Each phase in the operation of fsck consists of a loop iterating over either cylinder groups or directories. The new code tests 'got_siginfo' once at the start of each iteration and decides whether or not to do the printf; on large filesystems there may be a delay of a few seconds between the ^T and the message. Ian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi? <200012160120.aa45069>