Date: Sun, 07 Jan 2001 08:01:03 -0700 From: Warner Losh <imp@harmony.village.org> To: Peter Wemm <peter@netplex.com.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/pccard card_if.m pccard.c src/sys/dev/pccbb pccbb.c Message-ID: <200101071501.f07F13s06277@harmony.village.org> In-Reply-To: Your message of "Sun, 07 Jan 2001 05:33:46 PST." <200101071333.f07DXlt11106@mobile.wemm.org> References: <200101071333.f07DXlt11106@mobile.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200101071333.f07DXlt11106@mobile.wemm.org> Peter Wemm writes: : For what it is worth, this is all that would have been required to get : ray and oldcard to work without breaking newcard: : + if (offsetp) : + *offsetp = offset; Except that the NEWCARD stuff doesn't check offsetp not being null and always uses it. Also, the *offsetp parameter isn't what it sets the offset (in cardspace) to, but rather the delta from the requested value to the actual value. Since that was hard to do, I punted back on level and backed out the interface change. And there were a couple of other spots that you must have missed because sys/pccard/pccard.c also has the function in question, which means we'd hit stack garbage. I didn't want to break OLDCARD, even for a short while, which is why I went ahead and committed the back out. It seemed the easiest thing to do. I'm sorry that I broke NEWCARD in the process. If you'll send me some patches to try, I'll test both oldcard and newcard here (I have a ray card to test) and commit the change. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200101071501.f07F13s06277>