Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Jan 2001 19:17:04 -0800 (PST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Alfred Perlstein <bright@wintelcom.net>
Cc:        cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Kris Kennaway <kris@FreeBSD.org>, "Brian F. Feldman" <green@FreeBSD.org>
Subject:   Re: cvs commit: ports/net/micq Makefile
Message-ID:  <XFMail.010118191704.jhb@FreeBSD.org>
In-Reply-To: <20010118180520.U7240@fw.wintelcom.net>

next in thread | previous in thread | raw e-mail | index | archive | help

On 19-Jan-01 Alfred Perlstein wrote:
> * Brian F. Feldman <green@FreeBSD.org> [010118 17:58] wrote:
>> Alfred Perlstein <bright@wintelcom.net> wrote:
>> > * Kris Kennaway <kris@FreeBSD.org> [010118 15:45] wrote:
>> > > kris        2001/01/18 15:45:14 PST
>> > > 
>> > >   Modified files:
>> > >     net/micq             Makefile 
>> > >   Log:
>> > >   Remotely exploitable buffer overflow; FORBIDDEN.
>> > >   
>> > >   Submitted by:  recidjvo <recidjvo@pkcrew.org> via Bugtraq
>> > 
>> > "Obtained from" he did us no direct favors.
>> 
>> Submitted by applies to people, but Obtained from implies that the work to 
>> obtain it was done by FreeBSD's committers, therefore I'd say the correct 
>> thing in this case would be:
>> 
>> Obtained from: Bugtraq (recidjvo <recidjvo@pkcrew.org>)
>> 
>> This makes it clear that the report was gotten from a public source but not 
>> sent in.
>> 
>> Can we make this the accepted form for situations like this, if there are 
>> no strong objects?  I say strong because I don't want to help create a 
>> bikeshed problem...
> 
> I agree, I was also wondering about situations where someone does
> submit something however it's redone a bunch my the person who it
> was submitted to.
> 
> 'Pointed out by' doesn't give the submitter the credit he deserves
> for at least trying to supply a diff, but 'Submitted by' gives too
> much credit when the diff was actually reworked.  I've seen 'Submitted
> (in a different form) by' and I like that.
> 
> Does that work?  Anything better?

That's a bit long, maybe 'Submitted partially by:'?  Personally, I would expect
committers to clean stuff up, and if we are already a committer, that should
already be pumping our own egos up enough.  It doesn't hurt to give a little
credit to someone who did work on getting a patch in, even if it wasn't the
prettiest patch, so I would just go with the simpler 'Submitted by:'.  I do
agree with 'Obtained by:' in this case however.

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010118191704.jhb>