Date: Mon, 05 Feb 2001 14:38:39 -0800 From: Kent Stewart <kstewart@urx.com> To: Andrew Hesford <ajh3@hecubus.bsdonline.org> Cc: freebsd-stable@freebsd.org Subject: Re: Problems with netgraph in today's 4.2-STABLE Message-ID: <3A7F2B6F.4ED18797@urx.com> References: <20010205160412.A1535@cec.wustl.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Andrew Hesford wrote:
>
> I tried building today's -STABLE kernel, and it failed while building
> modules. There is a parse error in /usr/src/sys/netgear/ng_base.c, on
> line 602, in the function ng_findname().
>
> The error comes from having too many parentheses in the if condition in
> the LIST_FOREACH block, as seen below:
>
> /* Find node by name */
> LIST_FOREACH(node, &nodelist, nodes) {
> if (((node->name != NULL)
> && (strcmp(node->name, name) == 0))
> && (node->flags & NG_INVALID) == 0))
> break;
>
> The last closing parenthesis in that block, "&& (node->flags &
> NG_INVALID) == 0))", should be removed. This will allow compilation
> without errors.
Not really. That doesn't do what was intended. Re-cvsup. It has been
fixed.
Kent
>
> Happy building.
> --
> Andrew Hesford - ajh3@chmod.ath.cx
> "355/113 -- Not the famous irrational number PI,
> but an incredible simulation!"
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-stable" in the body of the message
--
Kent Stewart
Richland, WA
mailto:kbstew99@hotmail.com
http://kstewart.urx.com/kstewart/index.html
FreeBSD News http://daily.daemonnews.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A7F2B6F.4ED18797>