Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 25 Feb 2001 18:29:05 +1100 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/i386/conf NOTES src/sys/conf options
Message-ID:  <Pine.BSF.4.21.0102251811400.6130-100000@besplex.bde.org>
In-Reply-To: <200102241903.f1OJ3Jv66952@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 24 Feb 2001, John Baldwin wrote:

> jhb         2001/02/24 11:03:19 PST
> 
>   Modified files:
>     sys/i386/conf        NOTES 
>     sys/conf             options 
>   Log:
>   Add back in INVARIANT_SUPPORT and expand the comments in NOTES about it
>   to include the reasoning Eivind justifiably thwapped me over the head with.

Now removing INVARIANT_SUPPORT is back on my todo list :-].  It enables
a whole 28 lines of code (the _mtx_assert() function).  It seems to
be normal for INVARIANTS support code to be this small, so I think it
should be unconditional.  You got thwapped because _mtx_assert() was
conditional on the wrong option.  The smallness may have something to
do with large support code being put under other options, e.g., KTR.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0102251811400.6130-100000>