Date: Thu, 24 May 2001 09:56:09 -0700 From: "Kevin Oberman" <oberman@es.net> To: Will Andrews <will@physics.purdue.edu> Cc: will@FreeBSD.org, freebsd-ports@FreeBSD.org Subject: Re: ports/27064: New port of ThinkPad mWave ACP WinModem support Message-ID: <200105241656.f4OGu9c21467@ptavv.es.net> In-Reply-To: Your message of "Sun, 20 May 2001 20:59:48 CDT." <20010520205948.K1198@casimir.physics.purdue.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
> Date: Sun, 20 May 2001 20:59:48 -0500
> From: Will Andrews <will@physics.purdue.edu>
>
> On Sun, May 20, 2001 at 06:22:52PM -0700, Kevin Oberman wrote:
> > By the way, did you have an actual mWave APC to use to test this on?
>
> Nope. My rule is: if it can package properly, I assume the submitter
> knows it works. :-)
Unfortunately, now that I'm home from travel and have had a chance to
try the port, while it may package properly, some of the changes you
made broke the port. You removed patch-aa which makes a number of
corrections to modem.c. Without this patch, the code fails to work.
I can re-do these patches to be done with Perl, although patch looks
like a better tool to make more than one change in a single file:
--- modem.c.orig Sun Apr 22 17:14:17 2001
+++ modem.c Sun Apr 22 17:14:53 2001
@@ -59,7 +59,7 @@
DWORD modem_trc_flags=0x00000200; // see ./mwm/include/port_functions
-unsigned char * ini_file="/etc/mwavem.conf"; // default location for mwm ini f$+unsigned char * ini_file="/usr/local/etc/mwavem.conf"; // default location for$
int main(int argc, char **argv) {
BOOL bRC;
@@ -230,7 +230,6 @@
} else {
fprintf(stdout,"OK.\n");
fflush(stdout);
- fprintf(stdout,"mwave modem STARTED. To setup serial port use: $ fflush(stdout);
// Note: mwmParseHandleMessage replaces the message processing
// code from mwmw32/mwmwin.c
The other problem is that you modified the install procedure under
"drivers" to install the driver kernel module into share/mwave. While
it might work as well there, the startup script was not modified to
reflect this and the driver is not loaded.
I had to modify the Makefile with:
--- Makefile.orig Sat May 19 21:34:27 2001
+++ Makefile Wed May 23 11:43:53 2001
@@ -26,5 +26,5 @@
pre-build:
${PERL} -pi.orig -e "s@f /etc@f ${PREFIX}/etc@g" ${WRKSRC}/Makefile
- ${PERL} -pi.orig -e "s@ko /modules@ko ${PREFIX}/share/mwave@g" ${WRKSRC}/drivers/Makefile
+ ${PERL} -pi.orig -e "s@ko /modules@ko ${PREFIX}/modules@g" ${WRKSRC}/drivers/Makefile
${PERL} -pi.orig -e "s@install -m@install -c -m@g" \
Finally, since the kernel module is a driver, it really should be
loaded at boot time before the device probe. I see no way to do that
without installing the driver into /modules as /usr is not mounted
before the device probe. Is it permissible to install something in
/modules?
I will soon be submitting a change to fix up a couple of oversight on
my part when building the port and to add a man page for the tool and
will submit these as a pr. The author will soon have his new version
which will eliminate most (maybe all) of the patches shortly and will
take this into account, as well, if it is available in time.
Thanks again for the time you spent on this. The RE is clearly a better
way to patch the Makefiles!
R. Kevin Oberman, Network Engineer
Energy Sciences Network (ESnet)
Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab)
E-mail: oberman@es.net Phone: +1 510 486-8634
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200105241656.f4OGu9c21467>