Date: Wed, 23 May 2001 01:11:12 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/kdump mkioctls Message-ID: <Pine.BSF.4.21.0105230100540.60933-100000@besplex.bde.org> In-Reply-To: <20010522150815.A99517@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 22 May 2001, Ruslan Ermilov wrote: > On Tue, May 22, 2001 at 09:38:12PM +1000, Bruce Evans wrote: > > On Mon, 21 May 2001, Ruslan Ermilov wrote: > > > > > On Mon, May 21, 2001 at 10:06:27AM -0700, Ruslan Ermilov wrote: > > > > ru 2001/05/21 10:06:27 PDT > > > > > > > > Modified files: > > > > usr.bin/kdump mkioctls > > > > Log: > > > > Work around the side effect of src/include/Makefile,v 1.137 changes. > > > > (The proper fix is to add missing #include directives.) > > > > > > > ... and to install missing headers to /usr/include. > > > > Actually, the proper fix is to implement headers properly, so that no > > #include directives are missing. > > > You mean, each header should include all required headers except probably > a few special like <sys/types.h> etc? Headers should include all the required headers and shall not have any namespace pollution. Usually, only special headers can be included to satisfy the first requirement, since including general ones with break the second requirement. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0105230100540.60933-100000>