Date: Tue, 21 Aug 2001 09:10:24 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: obrien@FreeBSD.ORG Cc: hackers@FreeBSD.ORG Subject: Re: header polution Message-ID: <13307.998377824@critter> In-Reply-To: Your message of "Mon, 20 Aug 2001 17:57:43 PDT." <20010820175743.A33795@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20010820175743.A33795@dragon.nuxi.com>, "David O'Brien" writes: >When compiling the `dict' port, one gets: > > In file included from /usr/include/machine/signal.h:54, > from /usr/include/sys/signal.h:178, > from /usr/include/signal.h:44, > from dict.h:33, > from clientparse.y:25: > /usr/include/machine/trap.h:105: warning: `T_USER' redefined > >This seems very wrong. Can't we rename "T_USER" in the kernel to >"_T_USER", or wrap it in _KERNEL? The comment in machine/signal.h(x86) >says: > > #include <machine/trap.h> /* codes for SIGILL, SIGFPE */ > >but does that mean we must expose the entire contents of trap.h to >userland? The problem is T_ is very common in lex source. We most certainly shouldn't. Everything but the needed bits should be #ifdef KERNEL. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13307.998377824>