Date: Sun, 9 Sep 2001 23:34:07 +0100 From: Josef Karthauser <joe@tao.org.uk> To: Peter Wemm <peter@wemm.org> Cc: Josef Karthauser <joe@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: CVSROOT cfg.pm commit_prep.pl Message-ID: <20010909233407.A846@tao.org.uk> In-Reply-To: <20010909151006.C69728@tao.org.uk>; from joe@tao.org.uk on Sun, Sep 09, 2001 at 03:10:06PM %2B0100 References: <200109080211.f882BZt86733@freefall.freebsd.org> <20010908215254.D8BCD380A@overcee.netplex.com.au> <20010909151006.C69728@tao.org.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
--zhXaljGHf11kAtnf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 09, 2001 at 03:10:06PM +0100, Josef Karthauser wrote: > On Sat, Sep 08, 2001 at 02:52:54PM -0700, Peter Wemm wrote: > > This is broken, it happens before the $Id$ spamming checks. You only > > want this to be run after all the sanity checks are done. Of course th= en > > you have to fix all the return's from the function. :-) >=20 > You mean that it happens before the spamming checks have had a > chance to complain? I was so worried about making sure that this > worked for remote commits I forgot that it probably modifies the > file directly when committing locally. I'll fix this. Hmm, looks like there's no clean way to do this. For a local commit the local file (in the committers's working directory) is modified. Unfortunately this all happens before the commit message is entered. If they abort the commit at this time the file will have already had it's $Id$ unexpanded. :( Is this acceptable? Joe --zhXaljGHf11kAtnf Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iEYEARECAAYFAjub7lEACgkQXVIcjOaxUBbvwACgrygrCpxHeAJxT6ld6JcuP5xw SckAn2ny1ge9Dcod4Q5BLtox2yAaajNK =kVwZ -----END PGP SIGNATURE----- --zhXaljGHf11kAtnf-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010909233407.A846>