Skip site navigation (1)Skip section navigation (2)
Date:      19 Jan 2002 11:51:13 -0500
From:      Joe Clarke <marcus@marcuscom.com>
To:        Anders Andersson <anders@hack.org>
Cc:        gnome@FreeBSD.ORG
Subject:   Re: deskutils/gnomepim
Message-ID:  <1011459073.62255.5.camel@shumai.marcuscom.com>
In-Reply-To: <20020119164923.GC20216@sushi.sanyusan.se>
References:  <20020119162813.GA25897@sushi.sanyusan.se> <1011458564.62255.3.camel@shumai.marcuscom.com>  <20020119164923.GC20216@sushi.sanyusan.se>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2002-01-19 at 11:49, Anders Andersson wrote:
> On Sat, Jan 19, 2002 at 11:42:43AM -0500, Joe Clarke wrote:
> > On Sat, 2002-01-19 at 11:28, Anders Andersson wrote:
> > > It seems that the expected result is inverted in gnomepim's Makefile.
> > > 
> > > If I define WITHOUT_PILOT then it builds gnomepim with pilot support and
> > > if I dont define WITHOUT_PILOT it happily builds without pilot-link and
> > > so on.
> > > 
> > > I will look at the Makefile to see if I have missed a studpid tweak or
> > > not.
> > 
> > You're absolutely right.  The Makefile should read:
> > 
> > .if !defined(WITHOUT_PILOT)
> > BUILD_DEPENDS= 
> > ${X11BASE}/lib/gnome-pilot/conduits/libemail_conduit.so:${PORTSDIR}/palm/gnomepilot-conduits
> > RUN_DEPENDS=   
> > ${X11BASE}/lib/gnome-pilot/conduits/libemail_conduit.so:${PORTSDIR}/palm/gnomepilot-conduits
> > .endif
> > 
> > But instead will add the depends when you _do_ define WITHOUT_PILOT.  Of
> > course, it goes on to do the right thing in other places, so this may
> > break the port.
> > 
> > The attached patch should fix things.
> 
> Hah, I cant belive I missed that '!' 
> 
> I will try this and report back if I find any problems.

The build will still fail since it looks like gnomepim ignores
--without-pisock.  I'm looking at it now.

Joe

> -- 
> Anders Andersson <anders@hack.org>
> UNIX, Networking and Security consultant
> +46 (0)705 87 53 35
> 



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-gnome" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1011459073.62255.5.camel>