Date: Sat, 16 Feb 2002 23:56:13 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Alfred Perlstein <bright@mu.org>, Poul-Henning Kamp <phk@critter.freebsd.dk>, arch@FreeBSD.ORG, jhb@FreeBSD.ORG, peter@wemm.org, jake@locore.ca Subject: Re: gettimeofday() and crhold()/crfree() (was Re: gettimeofday() Message-ID: <Pine.BSF.4.21.0202162354060.39539-100000@InterJet.elischer.org> In-Reply-To: <200202170712.g1H7Cxb48783@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
either way, could you do you timing tests on a NON-INVARIANT kernel to judge the difference this makes? In the mean while, John, is it really necessary to have this there? I can remove it (and the KASSERTS) in a flash if you'll let me... On Sat, 16 Feb 2002, Matthew Dillon wrote: > : > :I agree but jhb wants to have it that way... He wants to be able to catch > :anyone accessing the ucred of a thread that is in user space. I > :personally think we should just remove the code. > > It makes it rather difficult to work on the Giant pushdown code because > it's going to catch a majority of process blockages, making it difficult > for us to guage the effect of our Giant pushdown work and also making > it difficult to track down what Giant locks are still being obtained. > If John (John?) is going to insist on leaving that code in, then I will > have to commit the Giant-less crfree() code pretty much now to get > around the deficiency. > > Now, it may wind up being a good idea to have giant-less crfree() code > anyway, since crfree() is called from the VM system (and NFS, and the > file descriptor code, and the VFS subsystem, and a few other places > deep in the code). It will be rather difficult to get Giant pushed > down into those subsystems without fixing crfree() anyway, but the work > isn't likely to progress that far for a few weeks or a month or two > depending. > > -Matt > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0202162354060.39539-100000>