Date: Mon, 18 Mar 2002 14:33:38 -0800 From: "Crist J. Clark" <crist.clark@attbi.com> To: "Jacques A. Vidrine" <nectar@FreeBSD.org>, Shin-ichi YOSHIMOTO <yosimoto@waishi.jp>, Dag-Erling Smorgrav <des@ofug.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/chpass chpass.c pw_copy.c pw_copy.h Message-ID: <20020318143338.B60554@blossom.cjclark.org> In-Reply-To: <20020318212349.GA29060@madman.nectar.cc>; from nectar@FreeBSD.org on Mon, Mar 18, 2002 at 03:23:49PM -0600 References: <200203180222.g2I2Ms309830@freefall.freebsd.org> <20020318161250.1c35600c.yosimoto@waishi.jp> <xzpit7upc55.fsf@flood.ping.uio.no> <20020318170348.671ec4b5.yosimoto@waishi.jp> <20020318001922.Z29705@blossom.cjclark.org> <20020318212349.GA29060@madman.nectar.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 18, 2002 at 03:23:49PM -0600, Jacques A. Vidrine wrote:
> On Mon, Mar 18, 2002 at 12:19:22AM -0800, Crist J. Clark wrote:
> > chpass(8) is very, very naughty and uses __pw_scan().
>
> The underscores are a warning that it is being naughty. In this case,
> I was not ready to commit to an API for `pw_scan', so when it needed
> to be moved to libc, I hid it. I meant to revisit the issue one day,
> but so it goes.
>
> Do not rename it unless you intend for it to be a public API that will
> be maintained across releases. And don't forget to document it in
> that case.
Something else we can borrow from NetBSD. But I'm not sure if I like
the way pw_scan() is split across libc and libutil with them.
> [snip]
> > This isn't an issue in -STABLE, where pw_scan() is exposed to the
> > world properly in libc.
>
> No, it's not. There is no pw_scan in -STABLE's libc.
Whoops. You're right, chpass(8) is getting it out of pwd_mkdb(8) in
-STABLE. I probably was confusing our -STABLE implementation with
NetBSD 1.5.x.
--
Crist J. Clark | cjclark@alum.mit.edu
| cjclark@jhu.edu
http://people.freebsd.org/~cjc/ | cjc@freebsd.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020318143338.B60554>