Date: Thu, 21 Mar 2002 11:54:20 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Thomas Quinot <thomas@cuivre.fr.eu.org> Cc: freebsd-current@freebsd.org, Pierre Beyssac <beyssac@enst.fr> Subject: Re: i386/boot2.c patches Message-ID: <XFMail.20020321115420.jhb@FreeBSD.org> In-Reply-To: <20020320235500.A11929@melusine.cuivre.fr.eu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20-Mar-2002 Thomas Quinot wrote: > Le 2002-03-20, John Baldwin écrivait : > >> Looks mostly ok to me. Not entirely sure about the autoboot changes >> as it looks weird to load(kname) right before you change what kname >> is. I think the logic must somehow be wrong there. > > But this is what is currently in the code (as I mentioned in the PR, > 36015 is strictly a code clarification, with no functional change). > The load() function in boot2 ends with an exec() of the loaded binary. > It returns only if it has failed. The purpose of replacing kname > after load() has returned is to try to load /boot/kernel if we have > failed to load /boot/loader. I was just saying it looked weird in the old code as well. Your explanation helps explain why though. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020321115420.jhb>