Date: Sat, 30 Mar 2002 01:24:22 -0800 From: "David O'Brien" <obrien@FreeBSD.org> To: Mark Murray <mark@grondar.za> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/sort append.c extern.h fields.c files.c fsort.c init.c msort.c sort.1 sort.c tmp.c Message-ID: <20020330012421.A74485@dragon.nuxi.com> In-Reply-To: <200203300819.g2U8JSPL020154@grimreaper.grondar.org>; from mark@grondar.za on Sat, Mar 30, 2002 at 08:19:27AM %2B0000 References: <20020329234623.A67334@dragon.nuxi.com> <200203300819.g2U8JSPL020154@grimreaper.grondar.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 30, 2002 at 08:19:27AM +0000, Mark Murray wrote: > > > Make this compile on FreeBSD. Sort out VCS tags, fix warnings. > > Why did you rush to take these off the vendor branch?? > You make this sound as though I did it maliciously. :-( It seems gratuitous. > > Will there be future imports from NetBSD? > > Who knows? We could well get future updates from them; wheter that happens > by importing or simple diffing is not really important. Sort is small. You seem to now follow what an SCM is used for. If we have future updates from NetBSD they need to be vendor imports, not "simple diffs" committed. Otherwise the vendor branch is a waste and needless overhead. It also makes it much harder to see what we've changed relative to them. It also makes their $NetBSD$ IDs B.S. if they aren't updated to the version of the files the "simple patches" come from. > > If so the importer will much > > appreciate files remaining on the vendor branch for as long as possible. > > I put this in src/usr.bin because it was too small for contrib-type > treatment, and I want to treat it in a "grey area" way as far as updates > are concerned. That is fine, I am sure we will diverge the code some. > Lite/2 is a vendor branch, and that does not stop us fixing things there. Again, I am not against fixing. > The black/white rules for the vendor branch apply to contrib; I wanted to > do some fixes. Fixes are fine. 1/3 of this commit did not contain fixes -- append.c, msort.c, tmp.c. You also dicked around with the vendor __COPYRIGHT, which we don't do. Please restore it. > > If not, then why was it vendor imported. Please consider backing out > > (the way only cvs@) the NOP commits. > > What?? If the vendor branch offends you, ignore it. Pretend I "cvs add"ed > it. We stopped vendor importing ports for a reason. Anyway what makes you think a vendor branch offends me? What offends me is graciously and needlessly taking files off the vendor branch. -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020330012421.A74485>