Date: Mon, 1 Apr 2002 13:56:28 -0800 From: Alfred Perlstein <alfred@FreeBSD.org> To: David O'Brien <obrien@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/asr asr.c Message-ID: <20020401215628.GA93885@elvis.mu.org> In-Reply-To: <20020401135014.A23412@dragon.nuxi.com> References: <200204010609.g3169IU31260@freefall.freebsd.org> <20020401135014.A23412@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
* David O'Brien <obrien@FreeBSD.org> [020401 13:52] wrote:
> On Sun, Mar 31, 2002 at 10:09:18PM -0800, Alfred Perlstein wrote:
> > alfred 2002/03/31 22:09:18 PST
> >
> > Modified files:
> > sys/dev/asr asr.c
> > Log:
> > Remove erronious destroy_dev. Not sure what the author's intent was here
> > but this makes the driver not panic my -current box.
>
> Sigh. Last night on IRC I told you I would test this on both UP and SMP
> kernel's and commit it; and you said "OK". If you were just going to
> commit this you should have told me. Rather I stayed up an extra 3 hours
> into the wee hours setting up a test machine to do this with.
David, the fact that you are maintainer, have hardware and didn't
realize that this card calls destroy_dev in a stupid manner that
_always_ panic()s machines sort of negates any sympathy I might
have for your plight. There is no SMP issues, just misuse of
the {make,destroy}_dev API.
I spent hours trying to get this _unmaintained_ PoS working, so
don't nag me when you're the one who dropped the ball initially.
--
-Alfred Perlstein [alfred@freebsd.org]
'Instead of asking why a piece of software is using "1970s technology,"
start asking why software is ignoring 30 years of accumulated wisdom.'
Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020401215628.GA93885>