Date: Mon, 08 Apr 2002 16:47:00 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Josef Karthauser <joe@tao.org.uk> Cc: David Wolfskill <david@catwhisker.org>, current@freebsd.org Subject: Re: panic "sleeping without a mutex" in usb_task_thread Message-ID: <XFMail.20020408164700.jhb@FreeBSD.org> In-Reply-To: <20020408183829.GB85649@genius.tao.org.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08-Apr-2002 Josef Karthauser wrote: > On Mon, Apr 08, 2002 at 01:37:55PM -0400, John Baldwin wrote: >> >> On 08-Apr-2002 Josef Karthauser wrote: >> > On Mon, Apr 08, 2002 at 12:33:40PM -0400, John Baldwin wrote: >> > >> >> show witness isn't useful to most people so I would avoid it unless >> >> someone >> >> explicitly asks for it. The problem here is likely due to the >> >> usb_task_thread() not locking Giant when it starts up. >> > >> > We probably want this: >> >> Probably unless some USB specific locks are added instead, but this is the >> easier fix for the time being. >> > > Cool. I've committed this; where should I look to get a low down on > what to lock, when and how? Is there anything other than source to > refer to? Nothing besides the source really. If it's walking a list you might use a lock to protect the list for example, but then you might need to conditionally get Giant while performing an action on the list. > Joe -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020408164700.jhb>