Date: Sat, 20 Apr 2002 03:44:46 +0000 From: "J. Mallett" <jmallett@FreeBSD.ORG> To: "J. Mallett" <jmallett@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/uudecode uudecode.c Message-ID: <20020420034445.GH9585@FreeBSD.ORG> In-Reply-To: <200204200333.g3K3XeU36531@freefall.freebsd.org> References: <200204200333.g3K3XeU36531@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 19, 2002 at 08:33:40PM -0700, J. Mallett wrote: > jmallett 2002/04/19 20:33:40 PDT > > Modified files: > usr.bin/uudecode uudecode.c > Log: > Use fwrite(3) to write out the decoded information, as the b64 decoding stuff > won't NUL terminate the string for us, and so we're liable to pick up trailing > garbage, possibly tons of it. Furthermore, a NUL could appear at any time in a binary file, and this is what was killing the decoding of David's shared libraries, I think, as they were being 1) corrupted due to trying to print as a C string without a terminator 2) truncated eary. Big conical hat to myself. -- jmallett@FreeBSD.org | C, MIPS, POSIX, UNIX, BSD, IRC Geek. http://www.FreeBSD.org | The Power to Serve "We all need mirrors to remind ourselves who we are -- I'm no different." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020420034445.GH9585>