Date: Fri, 3 May 2002 18:01:21 -0400 From: Bosko Milekic <bmilekic@unixdaemons.com> To: Hiten Pandya <hiten@uk.FreeBSD.org> Cc: freebsd-hackers@FreeBSD.ORG Subject: Re: deltas for sys/kern/vfs_syscalls.c and sys/kern/vfs_subr.c Message-ID: <20020503180121.A72398@unixdaemons.com> In-Reply-To: <20020503214532.GA93432@hpdi.ath.cx>; from hiten@uk.FreeBSD.org on Fri, May 03, 2002 at 10:45:32PM %2B0100 References: <20020503214532.GA93432@hpdi.ath.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 03, 2002 at 10:45:32PM +0100, Hiten Pandya wrote: > Hi all, > > I am submitting a patch which removes the register keyword from > sys/kern/vfs_syscalls.c. The reason I am doing this is very simple. > > The 'register' keyword has no effect, as compilers do enough optimizations > on their own. Also, I have seen commits made before which do the same > thing which I am doing now. I have talked about this patch with jmallett, > and various other developers. > > This patch is located at: > http://storm.uk.FreeBSD.org/~hiten/diffs/vfs_syscalls.diff.1 Looks good. > The second issue, is what I am not very sure about, but I had a little > discussion about this with rwatson. The vfs_subr.c module contains > a large #if 0'ed section, which basically contains some sysctls. I > think it has been forgotten for removal, so I am submitting a delta which > can be used to remove that #if 0'ed section. > > Note, I am not very sure about this, that is why I am posting this to > -hackers. > > The patch is located at: > http://storm.uk.FreeBSD.org/~hiten/diffs/vfs_subr.c.diff.1 I don't think that removing the code is a problem. The real person to ask would be dillon, since he was the one who placed the #if 0 around the block. > Thanks. If anyone finds them interesting, please commit them to the > CVS repository. > > P.S. Please do not hesitate to contact me for more information reg. > these deltas. > > -- > Hiten Pandya > http://storm.uk.FreeBSD.org/~hiten > Finger hiten@storm.uk.FreeBSD.org for PGP public key > -- 4FB9 C4A9 4925 CF97 9BF3 ADDA 861D 5DBD E4E3 03C3 -- Bosko Milekic bmilekic@unixdaemons.com bmilekic@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020503180121.A72398>