Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 May 2002 20:24:31 +0300
From:      Ruslan Ermilov <ru@FreeBSD.org>
To:        Jake Burkholder <jake@locore.ca>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.bin/elf2aout elf2aout.c
Message-ID:  <20020520172431.GA97469@sunbay.com>
In-Reply-To: <20020520161739.GR73296@sunbay.com>
References:  <200205200756.g4K7ueM28492@freefall.freebsd.org> <20020520121514.A62759@locore.ca> <20020520161739.GR73296@sunbay.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--wRRV7LY7NUeQGEoC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 20, 2002 at 07:17:39PM +0300, Ruslan Ermilov wrote:
> On Mon, May 20, 2002 at 12:15:14PM -0400, Jake Burkholder wrote:
> > Apparently, On Mon, May 20, 2002 at 12:56:40AM -0700,
> > 	Ruslan Ermilov said words to the effect of;
> >=20
> > > ru          2002/05/20 00:56:40 PDT
> > >=20
> > >   Modified files:
> > >     usr.bin/elf2aout     elf2aout.c=20
> > >   Log:
> > >   s/u_int/u_int32_t/
> >=20
> > I would have preferred you to not commit this, it does nothing.
> >=20
> It makes code more MI, as u_int is not guaranteed to be 32 bit.
> This also makes it explicit that we're dealing with the elf32
> here, not elf64.
>=20
These would even better be declared using the Elf32_* types.
Could you please fix this?


Cheers,
--=20
Ruslan Ermilov		Sysadmin and DBA,
ru@sunbay.com		Sunbay Software AG,
ru@FreeBSD.org		FreeBSD committer,
+380.652.512.251	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age

--wRRV7LY7NUeQGEoC
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iD8DBQE86TFPUkv4P6juNwoRAu0BAJ45acT5NSoY9NgTjbRVAgNrBoYZJwCfTD6o
b7q2pGgD0m5suWlaPJjTs5M=
=hoM4
-----END PGP SIGNATURE-----

--wRRV7LY7NUeQGEoC--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020520172431.GA97469>