Date: Tue, 25 Jun 2002 11:11:05 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Julian Elischer <julian@FreeBSD.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: RE: PERFORCE change 13103 for review Message-ID: <XFMail.20020625111105.jhb@FreeBSD.org> In-Reply-To: <200206180725.g5I7PCQ51323@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18-Jun-2002 Julian Elischer wrote: > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=13103 > > Change 13103 by julian@julian_ref on 2002/06/18 00:24:27 > > Start cleaning up the mess I made when I changed APIs. > still doesn't quite work, but I've tracked down a lot of brainos > including a couple I haven't fixed yet. > > Affected files ... > > ... //depot/projects/kse/sys/alpha/alpha/trap.c#26 edit > ... //depot/projects/kse/sys/i386/i386/swtch.s#34 edit > ... //depot/projects/kse/sys/i386/i386/trap.c#51 edit > ... //depot/projects/kse/sys/i386/i386/vm_machdep.c#57 edit > ... //depot/projects/kse/sys/kern/init_main.c#42 edit > ... //depot/projects/kse/sys/kern/kern_exit.c#54 edit > ... //depot/projects/kse/sys/kern/kern_fork.c#70 edit > ... //depot/projects/kse/sys/kern/kern_proc.c#70 edit > ... //depot/projects/kse/sys/kern/kern_thread.c#70 edit > ... //depot/projects/kse/sys/sparc64/sparc64/trap.c#30 edit > > Differences ... > > ==== //depot/projects/kse/sys/alpha/alpha/trap.c#26 (text+ko) ==== > > @@ -301,6 +301,7 @@ > if (td->td_ucred != p->p_ucred) > cred_update_thread(td); > if ((p->p_flag & P_WEXIT) && (p->p_singlethread != td)) { > + mtx_lock_spin(&sched_lock); > PROC_LOCK(p); > thread_exit(); > /* NOTREACHED */ Can't do this. (Acquire spin lock before a sleep mutex.) > * First check that we shouldn't just abort. > - * But check if the are the single thread first! > + * But check if we are the single thread first! > */ > if ((p->p_flag & P_WEXIT) && (p->p_singlethread != td)) { > + mtx_lock_spin(&sched_lock); > PROC_LOCK(p); > thread_exit(); > /* NOTREACHED */ Same here. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020625111105.jhb>