Date: Sun, 14 Jul 2002 10:12:21 -0700 From: Mark Peek <mp@FreeBSD.org> To: Luigi Rizzo <luigi@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release/picobsd/build write_mfs_in_kernel.c Message-ID: <p05111a10b9575f70fc2d@[10.1.1.73]> In-Reply-To: <20020714095839.H74633@iguana.icir.org> References: <200207141209.g6EC9XBL099971@freefall.freebsd.org> <p05111a0bb95747d37370@[10.1.1.73]> <20020714093834.E74633@iguana.icir.org> <p05111a0db9575adde9d7@[10.1.1.73]> <20020714095839.H74633@iguana.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At 9:58 AM -0700 7/14/02, Luigi Rizzo wrote: > > Well, I guess you could say that I complained. I'll send a request to >> the cvsmeisters for a repo copy to (yet) another location. > >you are not in need -- you just asked who could be using it >and did not positively mention anyone. >Not that i am opposed to keeping it, just i do not see any >use... Let me phrase it a bit stronger. I have used this utility in the past for PowerPC porting and I foresee myself using it in the future. I don't see a need for you to continue carrying it around in the picobsd tree (especially if you're not using it) but I object to it being totally removed from the system. > > Well, write_mfs_in_kernel does a bit more error checking to ensure > > the user isn't shooting themselves in the foot. > >the only additional check is that the area where you would 'dd' >the data is all-zero. You still have plenty of ways to shoot >yourself in the foot by passing an invalid mfs image as argument >(and if the kernel area is non-zero, you _are_ passing an invalid >argument, the kernel in this case). Sure, and I could also 'dd if=boot0 of=/dev/acd0" rather than use disklabel. Having *some* sanity checks is better than nothing. Mark To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p05111a10b9575f70fc2d>