Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Jul 2002 09:03:19 -0400 (EDT)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Alan Cox <alc@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject:   RE: cvs commit: src/sys/alpha/alpha pmap.c src/sys/vm vm_page.c
Message-ID:  <XFMail.20020715090319.jhb@FreeBSD.org>
In-Reply-To: <200207142351.g6ENptlW038537@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 14-Jul-2002 Alan Cox wrote:
> alc         2002/07/14 16:51:55 PDT
> 
>   Modified files:
>     sys/alpha/alpha      pmap.c 
>     sys/vm               vm_page.c 
>   Log:
>    o Lock page queue accesses by vm_page_wire() that aren't
>      within a critical section.
>    o Assert that the page queues lock is held in vm_page_wire()
>      unless an Alpha.

Even in a critical section you still need the lock to ensure you
don't read stale data and to prevent others from writing to them
out from under you.

If the critical section in question is for pmap_growkernel(), then
I think you can actually remove it anyways.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020715090319.jhb>