Date: Wed, 2 Oct 2002 08:53:36 -0700 From: "David O'Brien" <obrien@FreeBSD.ORG> To: Tim Robbins <tjr@FreeBSD.ORG> Cc: Pete Carah <pete@ns.altadena.net>, current@FreeBSD.ORG Subject: Re: Tool make ordering, or something Message-ID: <20021002155336.GA73332@dragon.nuxi.com> In-Reply-To: <20021002164648.A79780@dilbert.robbins.dropbear.id.au> References: <200210020537.g925bQB1092943@ns.altadena.net> <20021002164648.A79780@dilbert.robbins.dropbear.id.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 02, 2002 at 04:46:48PM +1000, Tim Robbins wrote:
> The best we can do to src/bin/sh is to do something like this:
>
> #ifndef BOOTSTRAPPING
> fmtstr(s, 64, "[%td] ", jp - jobtab + 1);
We know when this hit the tree, so please use:
#if defined(BOOTSTRAPPING) && (__FreeBSD_version > 5000xy)
fmtstr(s, 64, "[%lld] ", (long long)(jp - jobtab + 1));
#else
fmtstr(s, 64, "[%td] ", jp - jobtab + 1);
#endif
It makes it clear which is the special case and which is the normal one;
it does not penaltize uptodate -CURRENT systems; and lastely lets us know
that when RELENG_5 is branched, we can totally remove it.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021002155336.GA73332>