Date: Thu, 24 Oct 2002 04:42:52 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: Mark Murray <markm@FreeBSD.ORG>, <cvs-committers@FreeBSD.ORG>, <cvs-all@FreeBSD.ORG> Subject: Re: cvs commit: src/include stdlib.h src/lib/libc/gen getbsize.3 getbsize.c Message-ID: <20021024043136.S23921-100000@gamplex.bde.org> In-Reply-To: <20021023180024.GA38880@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 23 Oct 2002, Steve Kargl wrote: > On Thu, Oct 24, 2002 at 04:00:32AM +1000, Bruce Evans wrote: > > On Wed, 23 Oct 2002, Mark Murray wrote: > > > > > markm 2002/10/23 07:18:07 PDT > > > > > > Modified files: > > > include stdlib.h > > > lib/libc/gen getbsize.3 getbsize.c > > > Log: > > > Make the first argument of getbsize a size_t* instead of an int*, as this is > > > what the quantity actually is. Fix an easy const while I'm here. > > > > This breaks binary compatibility on 64-bit machines. > > > > It also breaks world. > > cc -O -pipe -mcpu=pentiumpro -c /usr/src/usr.bin/systat/swap.c > /usr/src/usr.bin/systat/swap.c:61: conflicting types for `getbsize' > /usr/obj/usr/src/i386/usr/include/stdlib.h:230: previous declaration of `getbsize' > *** Error code 1 systat shouldn't declare it, but of course there will be a type mismatches in unchanged sources if the correct declaration is in scope (except possibly on i386's -- gcc by default doesn't warn about type mismatches between pointers that differ only in signedness). The following programs in usr/src use getbsize: df, ls, quot, pkg_install, pstat, du, systat Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021024043136.S23921-100000>