Date: Wed, 27 Nov 2002 02:02:12 +0200 From: Giorgos Keramidas <keramida@ceid.upatras.gr> To: Gary Jennejohn <garyj@jennejohn.org> Cc: dheeraj@ece.gatech.edu, ataraxia@cox.net, jstocker@tzi.de, freebsd-current@FreeBSD.org, cg@FreeBSD.org Subject: Re: Kernel broken Message-ID: <20021127000212.GC3188@gothmog.gr> In-Reply-To: <200211261534.gAQFXwXA012323@peedub.jennejohn.org> References: <1038321492.c7af40c0dhee@myrealbox.com> <200211261534.gAQFXwXA012323@peedub.jennejohn.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2002-11-26 16:33, Gary Jennejohn <garyj@jennejohn.org> wrote:
> Ray Kohler <ataraxia@cox.net> wrote:
> > On Tue, Nov 26, 2002 at 12:53:39PM +0100, Jan Stocker wrote:
> > > CVSuped (2 mins ago) -current kernel is broken:
> > >
> > > cc1: warnings being treated as errors
> > > /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_lock':
> > > /usr/src/sys/dev/sound/isa/ad1816.c:81: warning: dereferencing `void *' pointer
> > > /usr/src/sys/dev/sound/isa/ad1816.c:81: request for member `mtx_lock' in something not a structure or union
> > > /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_unlock': /usr/src/sys/dev/sound/isa/ad1816.c:87: warning: dereferencing `void *' pointer
> > > /usr/src/sys/dev/sound/isa/ad1816.c:87: request for member `mtx_lock' in something not a structure or union
> >
> > This turns out to be semi-reproduceable. I have this problem but the
> > committer who made the change can't reproduce it.
>
> I have the same problem, [...]
> The culprit seems to be a change in /sys/dev/sound/pcm/sound.h,
> where snd_mtx{un}lock() were changed from routines to macros which
> simply use mtx_{un}lock(). The routines required a ``void *'', but
> the macros require a ``struct mtx *''.
>
> The following drivers still declare the lock to be a ``void *'',
> which is totally bogus after the above mentioned change:
>
> /sys/dev/sound/isa/ad1816.c
> /sys/dev/sound/isa/mss.c
> /sys/dev/sound/isa/sbc.c
> /sys/dev/sound/pci/cmi.c
> /sys/dev/sound/pci/ds1.c
> /sys/dev/sound/pci/emu10k1.c
> /sys/dev/sound/pci/t4dwave.c
> /sys/dev/sound/pcm/ac97.c
> /sys/dev/sound/pcm/mixer.c
> /sys/dev/sound/pcm/sound.c
I successfuly rebuilt a kernel with the following revisions of these
files.
keramida@gothmog[02:01]/home/keramida> uname -v
FreeBSD 5.0-CURRENT #1: Tue Nov 26 22:30:31 EET 2002 ...
Can you check that you have the right revisions checked out:
$FreeBSD: src/sys/dev/sound/isa/ad1816.c,v 1.24 2002/06/09 14:20:17 hm Exp $
$FreeBSD: src/sys/dev/sound/isa/mss.c,v 1.78 2002/04/04 20:56:45 jhb Exp $
$FreeBSD: src/sys/dev/sound/isa/sbc.c,v 1.35 2002/04/04 20:56:45 jhb Exp $
$FreeBSD: src/sys/dev/sound/pci/cmi.c,v 1.17 2002/08/23 20:54:32 orion Exp $
$FreeBSD: src/sys/dev/sound/pci/ds1.c,v 1.27 2002/04/04 20:56:46 jhb Exp $
$FreeBSD: src/sys/dev/sound/pci/emu10k1.c,v 1.27 2002/11/25 17:07:33 cg Exp $
$FreeBSD: src/sys/dev/sound/pci/t4dwave.c,v 1.34 2002/10/17 03:45:34 marcel Exp $
$FreeBSD: src/sys/dev/sound/pcm/ac97.c,v 1.27 2002/08/23 06:19:28 orion Exp $
$FreeBSD: src/sys/dev/sound/pcm/mixer.c,v 1.27 2002/07/25 04:49:45 green Exp $
$FreeBSD: src/sys/dev/sound/pcm/sound.c,v 1.79 2002/11/25 17:17:42 cg Exp $
- Giorgos
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021127000212.GC3188>