Date: Wed, 04 Dec 2002 12:21:48 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Jake Burkholder <jake@FreeBSD.org> Subject: Re: cvs commit: src/lib/libfetch Makefile Message-ID: <XFMail.20021204122148.jhb@FreeBSD.org> In-Reply-To: <20021204125653.GC31683@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04-Dec-2002 Ruslan Ermilov wrote: > On Tue, Dec 03, 2002 at 08:34:59PM -0800, Jake Burkholder wrote: >> jake 2002/12/03 20:34:59 PST >> >> Modified files: >> lib/libfetch Makefile >> Log: >> Reduce WARNS level to 3 in the non-crypto case to fix make release on sparc64. >> This may only be turning up now to changes in the cpp predefines for sparc64, >> which may be turning on more strict alignment checking. >> >> Approved by: re >> >> Revision Changes Path >> 1.37 +1 -1 src/lib/libfetch/Makefile >> > Would be more proper then to reduce the WARNS level for sparc64 only: That doesn't motivate the developer to fix their code to not emit warnings as much. :) The last time this came up with people cranking up WARNS on i386 but breaking Alpha the decision was to lower WARNS to the lowest common WARNS level on all archs. > Index: Makefile > =================================================================== > RCS file: /home/ncvs/src/lib/libfetch/Makefile,v > retrieving revision 1.37 > diff -u -r1.37 Makefile > --- Makefile 4 Dec 2002 04:34:59 -0000 1.37 > +++ Makefile 4 Dec 2002 12:55:44 -0000 > @@ -16,7 +16,11 @@ > WARNS?= 2 > .endif > > +.if ${MACHINE_ARCH} == "sparc64" > WARNS?= 3 > +.else > +WARNS?= 5 > +.endif > > SHLIB_MAJOR= 3 > > > Cheers, > -- > Ruslan Ermilov Sysadmin and DBA, > ru@sunbay.com Sunbay Software AG, > ru@FreeBSD.org FreeBSD committer, > +380.652.512.251 Simferopol, Ukraine > > http://www.FreeBSD.org The Power To Serve > http://www.oracle.com Enabling The Information Age -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20021204122148.jhb>