Date: Mon, 30 Dec 2002 07:47:45 -0800 From: Maxime Henrion <mux@freebsd.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_xl.c Message-ID: <20021230154745.GE27086@elvis.mu.org> In-Reply-To: <20021230235804.I46568-100000@gamplex.bde.org> References: <200212301246.gBUCk8VW075195@repoman.freebsd.org> <20021230235804.I46568-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans wrote: > On Mon, 30 Dec 2002, Maxime Henrion wrote: > > > mux 2002/12/30 04:46:08 PST > > > > Modified files: > > sys/pci if_xl.c > > Log: > > Leave only one of the two $FreeBSD$ tag, and use __FBSDID(). > > > > Revision Changes Path > > 1.114 +3 -6 src/sys/pci/if_xl.c > > This removes the wrong tag IMO. Id strings are not normally used in the > kernel. The places that do use them mostly have duplicate $FreeBSD$'s. > The main places are netatm and wpaul's network drivers. if_xl.c was one > of the latter. In netatm files, one of the tags should be the vendor > tag and the other should be the FreeBSD tag. In the network drivers, > there should be only one tag. I agree that there should only be one tag, and that's why I did this change in the first place. I don't understand why it would be bad to have Id strings in the kernel though. I find it a very useful feature when you want to know what file revisions the kernel was compiled with. Moreover, style(9) doesn't seem to say that we shouldn't use __FBSDID in the kernel. If there is a consensus that __FBSDID shouldn't be used in the kernel, I would like to know why and it also should be documented in style(9). Cheers, Maxime To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021230154745.GE27086>