Date: Tue, 31 Dec 2002 19:10:54 -0600 (CST) From: "M. Warner Losh" <imp@bsdimp.com> To: obrien@FreeBSD.org Cc: anders@hack.org, phk@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile Message-ID: <20021231.191054.18365679.imp@bsdimp.com> In-Reply-To: <20021231204901.GA87057@dragon.nuxi.com> References: <20021231175547.GA85448@dragon.nuxi.com> <20021231.141530.100232295.imp@bsdimp.com> <20021231204901.GA87057@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20021231204901.GA87057@dragon.nuxi.com>
"David O'Brien" <obrien@FreeBSD.org> writes:
: On Tue, Dec 31, 2002 at 02:15:30PM -0600, M. Warner Losh wrote:
: > : Well, this change will probably go back in -- PHK did a 100% against the
: > : rules back out of my commit. I haven't seen any bug reports in
: > : freebsd-current or my inbox about my commit upping the the size causing
: > : problems.
: >
: > This is not 100% against the rules. You committed something, things
: > broke, phk restored the status quo while things could be resolved.
: > Standard operating proceedure as far as I can tell. I'd go with maybe
: > 10-20% against the rules for not emailing you first, but 100%
: > overstates things too much.
:
: If this isn't 100% against the rules then why the fck did I land in the
: box for doing just this the end of October?!? Things were not BROKE.
: "make release" built. One of many code paths seems to have a bug. Again
: just like happened with libfetch in October. (except I didn't get any
: bug report)
Things just like this? Your case was a lot more complex. I voted to
put you in the box as much for attitude as for actions.
: Also can a committer back out a maintainer approved commit w/o asking the
: maintainer first? re@ is the maintainer of release/Makefile and my
: commit had their full backing.
I think you are making too big a deal out of this. Your change can
still stand once we work out what's wrong technically. Throwing blame
around isn't going to get that done. Let's stop playing lawyer over
these things and get down to the real thing we need to get done:
What, technically, broke for some people with the larget chunk size,
and what needs to be fixed to make those people happy.
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021231.191054.18365679.imp>