Date: Thu, 09 Jan 2003 22:15:22 -0800 From: Peter Wemm <peter@wemm.org> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: "David O'Brien" <obrien@FreeBSD.ORG>, Scott Long <scott_long@btc.adaptec.com>, Takahashi Yoshihiro <nyan@jp.FreeBSD.org>, re-builders@FreeBSD.ORG, bmah@FreeBSD.ORG, re@FreeBSD.ORG Subject: Re: 5.0-RC3 Message-ID: <20030110061522.068C32A8A0@canning.wemm.org> In-Reply-To: <20030110014820.GB17013@athlon.pn.xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Marcel Moolenaar wrote:
> On Thu, Jan 09, 2003 at 05:36:49PM -0800, David O'Brien wrote:
> > On Thu, Jan 09, 2003 at 05:25:49PM -0800, Marcel Moolenaar wrote:
> > > Let's start the release and have Takahashi-san apply Soren's
> > > patch as an exception. That way it gets some testing and
> > > should increase confidence for a post-RC3 merge.
> >
> > Actually that is the opposite of what should happen -- we need to have
> > Soren's MFC exposed as widely as possible if it is to be in 5.0-R. The
> > way we can get wide[r] coverage is putting it in RC3.
>
> I don't know what the change is, but if it has possible impact on
> non-pc98, then yes.
Well, without it, the ata driver will assume that all plug-n-play hardware
(including acpi enumerated devices) are ata devices and will attempt to
probe/attach them. It is nasty.
----------------------------
revision 1.3
date: 2003/01/09 14:00:07; author: sos; state: Exp; lines: +4 -0
Dont probe PnP devices.
Submitted by: Takahashi Yoshihiro <nyan@FreeBSD.org>
----------------------------
--- ata-cbus.c 17 Dec 2002 16:26:22 -0000 1.2
+++ ata-cbus.c 9 Jan 2003 14:00:07 -0000 1.3
@@ -60,4 +60,8 @@
int rid;
u_long tmp;
+
+ /* dont probe PnP devices */
+ if (isa_get_vendorid(dev))
+ return (ENXIO);
/* allocate the ioport range */
This is a no-brainer and should be MFC'ed. IMHO, dont even wait for sos.
Just Do It. We have this code on all the isa drivers that do not have
a specific list of PNP id's.
Cheers,
-Peter
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ia64" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030110061522.068C32A8A0>