Date: Tue, 14 Jan 2003 14:20:32 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: "David O'Brien" <obrien@FreeBSD.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Jeffrey Hsu <hsu@FreeBSD.org> Subject: Re: cvs commit: src/sys/netinet tcp_input.c tcp_seq.h tcp_timer. Message-ID: <XFMail.20030114142032.jhb@FreeBSD.org> In-Reply-To: <20030114163519.GA48612@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14-Jan-2003 David O'Brien wrote: > On Mon, Jan 13, 2003 at 10:54:45AM -0800, Jeffrey Hsu wrote: >> > hsu 2003/01/13 03:01:20 PST >> > >> > Modified files: >> > sys/netinet tcp_input.c tcp_seq.h tcp_timer.c >> > tcp_var.h >> > Log: >> > Fix NewReno. >> > >> > Reviewed by: Tom Henderson <thomas.r.henderson@boeing.com> >> > >> > Revision Changes Path >> > 1.187 +44 -41 src/sys/netinet/tcp_input.c >> > 1.19 +1 -1 src/sys/netinet/tcp_seq.h >> > 1.56 +2 -5 src/sys/netinet/tcp_timer.c >> > 1.84 +3 -1 src/sys/netinet/tcp_var.h >> >> The state for when we are enter, are in, and leave the NewReno Fast Recovery >> period has been split out from t_dupacks into its own state variable, snd_high, > ...snip... > > You should do a forced commit (cvs ci -f ..list.of.files..) and add this. Yes, please. Commit logs are meant to be informative. When browsing a long history of commits via cvs log, one doesn't want to have to do a diff each time to figure out what the log messages really mean. Just because a committer understands the commit they are making at the time doesn't mean that they will fully remember it later on and doesn't mean that other people who come along later will understand it either. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030114142032.jhb>