Date: 14 Feb 2003 17:36:01 -0800 From: Arun Sharma <arun.sharma@intel.com> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: freebsd-ia64@FreeBSD.ORG Subject: Re: Maxmem should be bytes ? Message-ID: <ud6lu1g1q.fsf@unix-os.sc.intel.com> In-Reply-To: <20030214010244.GA1344@athlon.pn.xcllnt.net> References: <200302080111.h181Bkr26574@unix-os.sc.intel.com> <u1y2b3eb7.fsf@unix-os.sc.intel.com> <20030214002346.GA1267@athlon.pn.xcllnt.net> <uvfzn1yev.fsf@unix-os.sc.intel.com> <20030214010244.GA1344@athlon.pn.xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Marcel Moolenaar <marcel@xcllnt.net> writes: > > New code that tries to use ia64_ptob(Maxmem) for something other than > > VHPT sizing would be broken. > > Like machdep.c:164? > > printf("real memory = %ld (%ld MB)\n", ia64_ptob(Maxmem), > ia64_ptob(Maxmem) / 1048576); This one is ok, because it's before line 598. Any code executed after line 598 would be broken. > > As for the fact that Maxmem is in bytes and physmem isn't: we define > Maxmem to be equal to physmem (machdep.c:598). So they are in fact > equal. All I'm saying is: --- machdep.c.old Fri Feb 14 17:32:26 2003 +++ machdep.c Fri Feb 14 17:33:22 2003 @@ -595,7 +595,7 @@ } phys_avail[phys_avail_cnt] = 0; - Maxmem = physmem; + Maxmem = ia64_ptob(physmem); init_param2(physmem); /* i386 does something equivalent. -Arun To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ia64" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ud6lu1g1q.fsf>