Date: Mon, 05 May 2003 11:50:19 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Juli Mallett <jmallett@FreeBSD.org> Cc: "M. Warner Losh" <imp@bsdimp.com> Subject: Re: PERFORCE change 30435 for review Message-ID: <XFMail.20030505115019.jhb@FreeBSD.org> In-Reply-To: <20030503233424.A8651@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04-May-2003 Juli Mallett wrote: > * "M. Warner Losh" <imp@bsdimp.com> [ Date: 2003-05-03 ] > [ w.r.t. Re: PERFORCE change 30435 for review ] >> In message: <200305030240.h432elND072264@repoman.freebsd.org> >> Juli Mallett <jmallett@freebsd.org> writes: >> : http://perforce.freebsd.org/chv.cgi?CH=30435 >> : >> : Change 30435 by jmallett@jmallett_dalek on 2003/05/02 19:40:13 >> : >> : Erk, remove redundant call to cp0_status_read. >> : >> : Affected files ... >> : >> : .. //depot/projects/mips/sys/mips/include/cpufunc.h#8 edit >> : >> : Differences ... >> : >> : ==== //depot/projects/mips/sys/mips/include/cpufunc.h#8 (text+ko) ==== >> : >> : @@ -38,7 +38,6 @@ >> : { >> : register_t s; >> : >> : - s = mips_cp0_status_read(); >> : mips_cp0_status_write((s = mips_cp0_status_read()) & ~MIPS_SR_IE); >> : return (s); >> : } >> >> Sure this is really redundant and not there for some weird mips box's >> pipeline delay requirements? > > I just forgot to dd the line after I decided to nest it. I personally find the unnested version easier to read. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030505115019.jhb>