Date: Mon, 7 Jul 2003 00:47:22 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: charnier@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/lpr/lpd lpd.c ... Message-ID: <20030707074722.GA27746@dragon.nuxi.com> In-Reply-To: <20030706.225203.52907520.imp@bsdimp.com> References: <20030707003216.GI72093@elvis.mu.org> <p05210650bb2e737f369a@[128.113.24.47]> <20030707040326.GB26228@dragon.nuxi.com> <20030706.225203.52907520.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jul 06, 2003 at 10:52:03PM -0600, M. Warner Losh wrote:
> In message: <20030707040326.GB26228@dragon.nuxi.com>
> "David O'Brien" <obrien@FreeBSD.org> writes:
> : On Sun, Jul 06, 2003 at 09:20:37PM -0400, Garance A Drosihn wrote:
> : > Well, any change to use __FBSDID() has to #include <sys/cdefs.h>
> : > to get FBSDID() to work. Of course, /usr/include/sys/cdefs.h
> : > does not exist on all platforms either (and is certainly not
> : > likely to define __FBSDID even if the file does exist), so that's
> : > just more of an annoyance when I'm doing cross-platform work.
> :
> : #ifdef __FreeBSD__
> : #include <sys/cdefs.h>
> : __FBSDID("$FreeBSD$");
> : #endif
>
> #include <sys/cdefs.h>
> #ifdef __FBSDID
> __FBSDID("$FreeBSD$");
> #endif
>
> might be better...
Not really -- Garance needed to deal with <sys/cdefs.h> not existing
everywhere -- that was one of his key issues.
--
-- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030707074722.GA27746>