Date: Wed, 30 Jul 2003 16:59:48 -0500 (CDT) From: Mike Silbersack <silby@silby.com> To: Pierre Beyssac <pb@fasterix.frmug.org> Cc: freebsd-current@freebsd.org Subject: Re: bug in big pipe code causing performance problems Message-ID: <20030730165830.L88169@odysseus.silby.com> In-Reply-To: <20030730215538.GA1672@fasterix.frmug.org> References: <20030730213249.GA900@fasterix.frmug.org> <20030730215538.GA1672@fasterix.frmug.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 30 Jul 2003, Pierre Beyssac wrote:
> On Wed, Jul 30, 2003 at 11:32:49PM +0200, Pierre Beyssac wrote:
> > - if (space > 0 && (wpipe->pipe_buffer.cnt < PIPE_SIZE)) {
> > + if (space > 0
> > + && wpipe->pipe_buffer.cnt < wpipe->pipe_buffer.size) {
>
> PS : not-so-obvious after all since the above is equivalent to
> "(space > 0)" by itself, so I won't commit the above as is, and the
> real fix might be something more complicated...
> --
> Pierre Beyssac pb@fasterix.frmug.org pb@fasterix.freenix.org
> Free domains: http://www.eu.org/ or mail dns-manager@EU.org
Good timing. :)
I was just writing a reply which stated that (space > 0) would be
sufficient. However, as you point out, there might be something subtle
lurking around. I'll do some doublechecking tonight and get back to you.
Mike "Silby" Silbersack
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030730165830.L88169>