Date: Fri, 1 Aug 2003 11:25:14 -0700 (PDT) From: John Polstra <jdp@polstra.com> To: current@freebsd.org Cc: pmedwards@eircom.net Subject: Re: bge & vlan stranges Message-ID: <200308011825.h71IPEAs072047@strings.polstra.com> In-Reply-To: <20030801175724.F1C6D43F75@mx1.FreeBSD.org> References: <20030801175724.F1C6D43F75@mx1.FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In article <20030801175724.F1C6D43F75@mx1.FreeBSD.org>, Peter Edwards <pmedwards@eircom.net> wrote: > John Polstra <jdp@polstra.com> wrote: > > [snip] > >> I assume you mean, that after setting if_hdrlen, > [snip] > > I think you also have to set if_data.ifi_hdrlen as I said > [snip] > > My fault: I jumped from one term for the same thing to the other > without explanation. if_hdrlen is a macro for if_data.ifi_hdrlen. Understood. I was just trying to make the point that you have to set that in addition to setting the MTU register in the hardware. > I'm not a big fan of hiding those kind of details with macros, but I > assume they're defined by smarter people than me in order that > they be used :-) I don't know why the fxp driver doesn't use the macro. Maybe the macro didn't exist yet when that code was added. John -- John Polstra John D. Polstra & Co., Inc. Seattle, Washington USA "Two buttocks cannot avoid friction." -- Malawi saying
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200308011825.h71IPEAs072047>