Date: Sun, 14 Dec 2003 12:23:01 +0000 From: Nate Grey <NateBSD@yahoo.it> To: Maxim Konovalov <maxim@macomnet.ru> Cc: net@FreeBSD.org Subject: Re: Fwd: 5.2-RC + ipfw Message-ID: <200312141223.01385.NateBSD@yahoo.it> In-Reply-To: <20031213214424.E42015@news1.macomnet.ru> References: <200312131149.44582.NateBSD@yahoo.it> <20031213214424.E42015@news1.macomnet.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 13 December 2003 18:47, Maxim Konovalov wrote:
> Please try an enclosed patch or put a whitespace right after the '('
> before '\'.
>
> Index: ipfw2.c
> ===================================================================
> RCS file: /home/ncvs/src/sbin/ipfw/ipfw2.c,v
> retrieving revision 1.42
> diff -u -r1.42 ipfw2.c
> --- ipfw2.c 31 Oct 2003 18:31:55 -0000 1.42
> +++ ipfw2.c 13 Dec 2003 18:42:18 -0000
> @@ -2901,15 +2901,14 @@
> goto done;
>
> #define OR_START(target) \
> - if (ac && (*av[0] == '(' || *av[0] == '{')) { \
> + if (ac && ( \
> + !strncmp(*av, "(", strlen(*av)) || \
> + !strncmp(*av, "{", strlen(*av)) )) { \
> if (open_par) \
> errx(EX_USAGE, "nested \"(\" not allowed\n"); \
> prev = NULL; \
> open_par = 1; \
> - if ( (av[0])[1] == '\0') { \
> - ac--; av++; \
> - } else \
> - (*av)++; \
> + ac--; av++; \
> } \
> target: \
>
> %%%
Problem solved just adding a whitespace. Should I apply the patch anyway?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200312141223.01385.NateBSD>