Date: Sat, 24 Jan 2004 08:29:42 +0800 From: Sepherosa Ziehau <sepherosa@SoftHome.net> To: Matthew Seaman <m.seaman@infracaninophile.co.uk> Cc: "ports@FreeBSD.org" <ports@FreeBSD.org> Subject: Re: FreeBSD Port: jfreechart-0.9.13 Message-ID: <opr187nsrtt45q1u@mail.SoftHome.net> In-Reply-To: <20040123123924.GA49081@happy-idiot-talk.infracaninophile.co.uk> References: <opr177g61vt45q1u@mail.SoftHome.net> <20040123123924.GA49081@happy-idiot-talk.infracaninophile.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.
--=_charleston-26674-1074904272-0001-2
Content-Type: text/plain; format=flowed; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Mime-Autoconverted: from 8bit to 7bit by courier 0.38
On Fri, 23 Jan 2004 12:39:24 +0000, Matthew Seaman
<m.seaman@infracaninophile.co.uk> wrote:
> On Fri, Jan 23, 2004 at 07:28:08PM +0800, Sepherosa Ziehau wrote:
>> without a java document, a java library is useless. I have upgraded
>> jfreechart to 0.9.16 and add javadoc support.
>> Hope somebody can review it and commit it for me.
>
> Nice work. However, I can see a couple of problems with your patch.
>
> You're building javadocs with one of a number of possible JDKs, and
> that has the unfortunate consequence that the plist for the generated
> Javadocs is different for different JDK versions. You're also using
> ant(1) to do the build, which overrides the settings obtained by
> USE_JAVA=x.y and instead uses whatever the default JDK on the system
> is. (Normally those JDKs will be the same, but not always.)
>
> You can easily solve the pkg-plist problem by use of the PORTDOCS make
> variable -- which also has the handy side effect of keeping the
> pkg-plist file for the port nice and short. See the
> databases/mysql-connector-java port I maintain for an example.
>
> You can (if you think it's necessary) solve the ant(1) version problem
> by:
>
> ANT= ${SETENV} JAVA_HOME=${JAVA_HOME} ant
>
> You also need a BUILD_DEPENDS on the devel/apache-ant port.
>
> Cheers,
>
> Matthew
>
Thank you for your advice, and the nice mysql-connector.
I regenerated the patch according to your advice.
Please review it.
Best Regards
Sepherosa
--=_charleston-26674-1074904272-0001-2
Content-Type: application/octet-stream; name="patch.jfreechart"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=patch.jfreechart
X-Mime-Autoconverted: from 8bit to 7bit by courier 0.38
--- jfreechart.orig/Makefile Sat Jan 24 08:22:12 2004
+++ jfreechart/Makefile Sat Jan 24 08:17:40 2004
@@ -7,7 +7,7 @@
#
PORTNAME= jfreechart
-PORTVERSION= 0.9.13
+PORTVERSION= 0.9.16
CATEGORIES= java
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE}
MASTER_SITE_SUBDIR= ${PORTNAME}
@@ -15,10 +15,25 @@
MAINTAINER= ports@FreeBSD.org
COMMENT= A free Java class library for generating charts
+BUILD_DEPENDS= ${ANT}:${PORTSDIR}/devel/apache-ant
+
USE_JAVA= 1.2+
-NO_BUILD= yes
+
+ANT?= ${LOCALBASE}/bin/ant
+ANT_TARGETS= compile javadoc
+
+PORTDOCS= *
+
+do-build:
+ @cd ${WRKSRC}/ant && ${ANT} ${ANT_TARGETS}
do-install:
- ${INSTALL_DATA} ${WRKSRC}/${PORTNAME}-${PORTVERSION}.jar ${JAVAJARDIR}/${PORTNAME}.jar
+ @${ECHO_CMD} -n ">> Installing .jar file..."
+ @${INSTALL_DATA} ${WRKSRC}/${PORTNAME}-${PORTVERSION}.jar ${JAVAJARDIR}/${PORTNAME}.jar
+ @${ECHO_CMD} " [DONE]"
+ @${ECHO_CMD} -n ">> Installing documentation in ${DOCSDIR}..."
+ @${MKDIR} ${DOCSDIR}
+ @${CP} -r ${WRKSRC}/javadoc/* ${DOCSDIR}
+ @${ECHO_CMD} " [DONE]"
.include <bsd.port.mk>
--- jfreechart.orig/distinfo Sat Jan 24 08:22:12 2004
+++ jfreechart/distinfo Tue Jan 13 17:06:48 2004
@@ -1 +1 @@
-MD5 (jfreechart-0.9.13.tar.gz) = 69837930b853e7c623fc72c7c502cc1e
+MD5 (jfreechart-0.9.16.tar.gz) = 8f452cd7b22322e76ae633ba4e67724a
--=_charleston-26674-1074904272-0001-2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?opr187nsrtt45q1u>