Date: Wed, 3 Mar 2004 08:15:32 -0800 From: David Schultz <das@FreeBSD.ORG> To: Bruce Evans <bde@zeta.org.au> Cc: standards@FreeBSD.ORG Subject: Re: Another conformance question... This time fputs(). Message-ID: <20040303161532.GA27304@VARK.homeunix.com> In-Reply-To: <20040303195618.K1351@gamplex.bde.org> References: <F648D56F-6C28-11D8-9000-000393BB9222@queasyweasel.com> <20040302165323.GA17665@VARK.homeunix.com> <20040303144451.T5253@gamplex.bde.org> <0805074F-6CC9-11D8-9000-000393BB9222@queasyweasel.com> <20040303195618.K1351@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 03, 2004, Bruce Evans wrote: > This is the only failure case. It bogusly returns EOF instead of boolean > true. We can set errno to EBADF here if we have no idea why __SRW is > clear. But we should know. I think the cases are: > (1) a normal fopen() for reading only. Then EBADF is correct. > (2) funopen() with no writer, or fropen(). I think this can be determined > by checking the function pointer that we write through. Then write is > just unsupported and an errno like ENOTSUP is better than EBADF. > (3) otherwise, we will call the underlying function and there is no problem > here. The underlying function just needs to set errno if it fails, and > old ones probably don't. > So the only immediate problem with returning EBADF in all cases seems to be > in case (2) which is not very interesting. One could argue that EBADF is a perfectly reasonable error code to return in case (2) as well. It is consistent with the way other types of stdio streams work. Specifically, if the stream isn't writable (either because it was opened read-only and we don't have permission or because it was opened without a writefn and we don't support it) then we should get a single error code that reflects the fact that the stream isn't writable. The fputs(3) man page even says: [EBADF] The _stream_ argument is not a writable stream. It doesn't say anything about why the stream is not writable. Thus, there shouldn't be a problem with simply setting errno to EBADF in all failure cases in __swsetup().
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040303161532.GA27304>