Date: Mon, 29 Mar 2004 23:42:12 -0800 From: Luigi Rizzo <rizzo@icir.org> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: current@freebsd.org Subject: Re: proposed bsdlabel patch Message-ID: <20040329234212.A72990@xorpc.icir.org> In-Reply-To: <20040329230643.B70930@xorpc.icir.org>; from rizzo@icir.org on Mon, Mar 29, 2004 at 11:06:43PM -0800 References: <20040329163926.A38109@xorpc.icir.org> <20040330005013.GA53546@ns1.xcllnt.net> <20040329230643.B70930@xorpc.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
actually, following up to myself:
you do need some way to disambiguate between the case of a device
("bsdlabel ad0") and a file in the current directory ("bdslabel
ad0"). This is why i introduced '-f' in the first place, and I
think either that or requiring absolute pathnames for files cannot
go away. As to which one is preferrable i am neutral.
Note that there are several utilities which have the same
problem with ambiguous command line syntax.
cheers
luigi
On Mon, Mar 29, 2004 at 11:06:43PM -0800, Luigi Rizzo wrote:
> On Mon, Mar 29, 2004 at 04:50:13PM -0800, Marcel Moolenaar wrote:
> > On Mon, Mar 29, 2004 at 04:39:26PM -0800, Luigi Rizzo wrote:
> > > if there are no strong objections, I'd like to commit
> > > the following minor patch to bsdlabel (and associated bsdlabel.8
> > > changes) to implement a '-f' option which enables bsdlabel to
> > > work on an image file too.
> >
> > As Julian mentioned, why not use stat(2) and DTRT without options?
> > That also removes the gratuitous requirement that the filename has
> > to be an absolute path. See also the implementation of gpt(8)...
>
> sure, will do that, and take care of the style bugs as bruce
> suggested (the original patch was voluntarily formatted in
> a way to reduce the diffs).
>
> thanks for the feedback
> cheers
> luigi
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040329234212.A72990>