Date: Sat, 10 Apr 2004 23:06:40 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Kris Kennaway <kris@obsecurity.org> Cc: freebsd-bugs@freebsd.org Subject: Re: misc/65212: running startx hangs the system Message-ID: <20040410225603.R25530@gamplex.bde.org> In-Reply-To: <20040410033937.GA66374@xor.obsecurity.org> References: <200404060110.i361AOiC038363@freefall.freebsd.org> <20040406045132.GA63152@gilberto.physik.rwth-aachen.de> <20040406045617.GA63319@gilberto.physik.rwth-aachen.de> <20040410132923.G24073@gamplex.bde.org> <20040410033937.GA66374@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 9 Apr 2004, Kris Kennaway wrote:
> On Sat, Apr 10, 2004 at 01:33:47PM +1000, Bruce Evans wrote:
> > On Fri, 9 Apr 2004, Kris Kennaway wrote:
> > > Were you using any modules? They need to be recompiled for SMP.
> >
> > Er, modules shouldn't depend on any options. None in the tree changed
> > when I tested rebuilding them with -DSMP.
>
> Maybe this changed at some point recently, but it used to be the case
> (and still is on 4.x?).
This hasn't changed for at least 5 years. An example of the the support
for modules being independent of SMP:
% RCS file: /home/ncvs/src/sys/i386/include/atomic.h,v
% Working file: atomic.h
% head: 1.32
% ...
% ----------------------------
% revision 1.3
% date: 1999/07/13 06:35:25; author: alc; state: Exp; lines: +58 -38
% Commit the correct patch, i.e., the one that actually corresponds
% to the rev 1.2 log entry.
% ----------------------------
% revision 1.2
% date: 1999/07/13 03:32:17; author: alc; state: Exp; lines: +42 -22
% Changed the implementation of the primitives to guarantee atomicity
% with respect to interrupts on UP systems. (The upgrade from gcc 2.7.x
% to egcs 1.1.2 produced at least one non-atomic code sequence in
% swap_pager_getpages.)
%
% In addition, the primitives are now SMP-safe, but only on SMPs. (For
^^^^
% portability between SMPs and UPs, modules are compiled with the SMP-safe
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
% versions.)
^^^^^^^^^^
%
% Submitted by: dillon and myself
% Reviewed by: bde
% ----------------------------
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040410225603.R25530>