Date: Mon, 3 May 2004 01:14:23 -0700 From: Kris Kennaway <kris@obsecurity.org> To: Kris Kennaway <kris@obsecurity.org>, Pete Fritchman <petef@absolutbsd.org>, freebsd-ports <freebsd-ports@freebsd.org> Subject: Re: [PATCH] small speedups in Mk/bsd.port.mk Message-ID: <20040503081423.GA99522@xor.obsecurity.org> In-Reply-To: <20040503080953.GA12341@isis.wad.cz> References: <20040502050806.C12FB177CB@sirius.firepipe.net> <20040502070355.GA345@isis.wad.cz> <20040503065209.GA92943@xor.obsecurity.org> <20040503080953.GA12341@isis.wad.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
--5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 03, 2004 at 10:09:53AM +0200, Roman Neuhauser wrote: > # kris@obsecurity.org / 2004-05-02 23:52:09 -0700: > > On Sun, May 02, 2004 at 09:03:55AM +0200, Roman Neuhauser wrote: > >=20 > > > Hrmph, right, dot is just one of regexp metacharacters. > > > This version uses plain string comparisons in DISTINFO_SIZE_AWK a= nd > > > DISTINFO_CKSUM_AWK. > > >=20 > > > Thanks again for testing! This would have taken weeks if I submit= ted > > > the patch right away. > >=20 > > But that's why you should always test patches thoroughly before > > submitting them, right? ;-) >=20 > Yes, and I didn't mean to imply anything except that dealing with > portmgr@ is slow business. > =20 > As I said, my box has cooling problems, e. g. it couldn't finish two > consecutive builds of mod_php4 yesterday. Plus, testing can't prove > absence of bugs, and I of course tested all changes, but missed some > things, like the fact that there are more RE metacharacters than > just the dot. That's what public testing is good for, right? :) >=20 > BTW any progress with ports/40699? Average response time from > portmgr@ 7 months, and it's been suspended ("the patch doesn't apply > anymore"; no wonder two years after it's been submitted :) for more > than month despite three new versions of the patch? We'll be able to look at it once 4.10 is out the door. Kris --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAlf9eWry0BWjoQKURArWwAJ9fC7bxlr9PaZH2L01Sj8ZcahPD0QCg0Pg7 X+4eHub+VoRd7f9L/8+qvY8= =klT6 -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040503081423.GA99522>