Date: Sun, 9 May 2004 22:06:06 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Timo Geusch <freebsd@unix-consult.com> Cc: freebsd-current@FreeBSD.org Subject: Re: sio: lots of silo overflows on Asus K8V with Moxa Smartio C104H/PCI Message-ID: <20040509220029.D8834@gamplex.bde.org> In-Reply-To: <20040509101356.GA93300@odie.unix-consult.com> References: <Pine.NEB.3.96L.1040503130429.95554B-100000@fledge.watson.org> <20040509101356.GA93300@odie.unix-consult.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 9 May 2004, Timo Geusch wrote: > On Tue, May 04, 2004 at 02:17:16PM +1000, Bruce Evans wrote: > > BTW, there are about 34 broken drivers that use > > BUS_SETUP_INTR(device_get_parent(...), ...) instead of bus_setup_interrupt(). > > This just evades printing of the FAST/GIANT-LOCKED/MPSAFE boot message. > > BUS_SETUP_INTR() seems to be needed in only 10 files. > > Is there a fairly simple way to indentify where BUS_SETUP_INTR is needed? > I might have a couple of hours to spare to look into this... I just grepped for "BUS_SETUP_INTR.*device_get_parent" . There is no reason to use BUS_SETUP_INTR() when bus_setup_intr() can do the same thing (except for printing the message. It might not be correct that bus_setup_intr() is the only place that prints the FAST/GIANT-LOCKED/MPSAFE message, but printing it in every layer would be wrong. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040509220029.D8834>