Date: Wed, 02 Jun 2004 15:50:49 +0200 From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: Kris Kennaway <kris@obsecurity.org> Cc: ports@FreeBSD.org Subject: Re: INDEX patch Message-ID: <40BDDB39.9090106@fillmore-labs.com> In-Reply-To: <20040602134340.GA55881@xor.obsecurity.org> References: <20040602121648.GA51625@xor.obsecurity.org> <40BDCC4B.9000708@fillmore-labs.com> <20040602132149.GA55452@xor.obsecurity.org> <40BDD8B6.80103@fillmore-labs.com> <20040602134340.GA55881@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Kris Kennaway wrote: > On Wed, Jun 02, 2004 at 03:40:06PM +0200, Oliver Eikemeier wrote: > >>Kris Kennaway wrote: >> >>>On Wed, Jun 02, 2004 at 02:47:07PM +0200, Oliver Eikemeier wrote: >>> >>>>Kris Kennaway wrote: >>>> >>>>>A previous commit to bsd.port.mk broke the reporting of missing >>>>>dependencies from 'make index'. This patch restores it (and makes >>>>>these errors fatal). I plan to commit it soon. >>>>> >>>>>Kris >>>> >>>>May I suggest the following patch: >>>> >>>>- check for existence of perl (cf. my RFC on ports-developers) >>>>- enables the use of `env PATH= /usr/bin/make describe' (nice for testing) >>> >>>Nice idea, but running this test 11000 times is suboptimal :-) >> >>Because test is a sh-builtin, and the file system should cache this >>information >>I don't expect to see any difference. Especially since spawning perl 11000 >>times >>is more than suboptimal ;) You didn't mean this serious, did you? > > I did, because I care about small pessimizations of the INDEX build. > Sometimes they're not small. Did you benchmark it? No. Did you? Honestly, when you really want to improve INDEX building times, it should be worth thinking about not spawning perl every time, but instead do the substitutions in batch. I my experience microoptimization on the expense of clarity and prudence almost always result in highly optimized suboptimal algorithms that together run far slower that they have to. -Oliver
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40BDDB39.9090106>