Date: Wed, 22 Sep 2004 00:39:46 -0700 From: Bruce M Simpson <bms@spc.org> To: Brian Fundakowski Feldman <green@freebsd.org> Cc: net@freebsd.org Subject: Re: IPv6 route mutex recursion (crash) and fix Message-ID: <20040922073946.GC4985@empiric.icir.org> In-Reply-To: <20040922025320.GF84424@green.homeunix.org> References: <20040922020957.GE84424@green.homeunix.org> <m21xgvxbui.wl@minion.local.neville-neil.com> <20040922025320.GF84424@green.homeunix.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 21, 2004 at 10:53:20PM -0400, Brian Fundakowski Feldman wrote: > Sorry, I should have provided a higher number of lines of context. > It prevents a call to nd6_lookup() and reentry into the route table > when entered via RTM_RESOLVE. I.e. nd6_rtrequest(), nd6_is_addr_neighbor(), > nd6_lookup(). I haven't tested your patch but the rationale for this sounds fine. Recursive locking attempts via the lookup code by way of neighbour discovery is a Bad Thing, and it would be useful to keep these semantics working for IPv6. So it looks good to me. BMS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040922073946.GC4985>