Date: Fri, 22 Oct 2004 10:53:11 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: soralx@cydem.org Cc: freebsd-hackers@freebsd.org Subject: Re: [PATCH] Re: Linksys PCM200 Message-ID: <20041022175311.GA15960@odin.ac.hmc.edu> In-Reply-To: <200410220216.54868.soralx@cydem.org> References: <200410132110.09915.soralx@cydem.org> <20041021173456.GA20517@odin.ac.hmc.edu> <20041021223525.GB4730@odin.ac.hmc.edu> <200410220216.54868.soralx@cydem.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 22, 2004 at 02:16:54AM -0600, soralx@cydem.org wrote: >=20 > > Could some people with dc(4) devices please test the following patch? > > It compiles for me and is trivial, but a quick test is probalby in order > > before I commit it. >=20 > It's rather necessary to test it well, because I didn't actually remove > the card's case to see the chip; I relied on my own tests and info from > the INet, thus some problems may appear if Linksys modified the chipset >=20 > Linksys PCM200 is the only 32-bit PCMCIA NIC available in Compusmart - > I'm sure that soon someone will buy the card, find the patch, and test > it. It's better to wait for feedback before committing the patch. If you have done any testing, that should be sufficent. After all, the hardware didn't work before, right? It did work before that's another issue, but if not, all that matters is that we don't break any other cards. > > This differs from soralx's patch in that it adds > > comments on the 0xab08 collisions and shortens the description string to > > something that will fit in one line on the console. >=20 > I suggest that you change the description to: > "Linksys PCM200 EtherFast 10/100 CardBus NIC, v.03 (ADMtek Centaur-C)" >=20 > Card's versions differ between each other significantly. Also, there will > be no easy way to find out card's chipset if it won't be stated in the > description. > The string will fit on console even better: >=20 > dc0: <Linksys PCM200 EtherFast 10/100 CardBus NIC, v.03 (ADMtek Centaur-C= )> port > 0x1000-0x10ff mem 0x88002000-0x880023ff irq 9 at device 0.0 on cardbus1 I disagree. If you need that level fo detail, you should use pciconf -lv. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --vtzGhvizbBRQ85DL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBeUkGXY6L6fI4GtQRAirHAKC4FqLc5S4J38KANxpONkFfhIWh2ACeJSnu RjhvpE7+UWDzt7EJY7vuzYg= =uBN4 -----END PGP SIGNATURE----- --vtzGhvizbBRQ85DL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041022175311.GA15960>