Date: Tue, 16 Nov 2004 16:24:10 +0200 From: Giorgos Keramidas <keramida@freebsd.org> To: Dmitry Morozovsky <marck@rinet.ru> Cc: freebsd-bugs@freebsd.org Subject: Re: misc/73992: periodic security not showing faily firewall diffs Message-ID: <20041116142410.GA48028@orion.daedalusnetworks.priv> In-Reply-To: <20041116165859.C57439@woozle.rinet.ru> References: <200411161200.iAGC0mir091454@freefall.freebsd.org> <20041116165859.C57439@woozle.rinet.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2004-11-16 17:00, Dmitry Morozovsky <marck@rinet.ru> wrote: >On Tue, 16 Nov 2004, Giorgos Keramidas wrote: >> Wouldn't a better fix be to change the default filter in check_diff() >> to make sure the correct pattern is used? I'm thinking of something >> like this: >> >> : Index: security.functions >> : =================================================================== >> : RCS file: /home/ncvs/src/etc/periodic/security/security.functions,v >> : retrieving revision 1.4 >> : diff -u -u -r1.4 security.functions >> : --- security.functions 23 Sep 2004 02:00:51 -0000 1.4 >> : +++ security.functions 16 Nov 2004 11:55:03 -0000 >> : @@ -44,6 +44,9 @@ >> : if [ "$1" = "new_only" ]; then >> : shift >> : filter="grep '^>'" >> : + case $daily_status_security_diff_flags in >> : + *-u*|*-c*) filter="grep '^+[^+]'" ;; >> : + esac >> : else >> : filter="cat" >> : fi > > It will miss changes in context diffs (they are marked by '!'), won't it? Hmmm, true. I have to think of this a bit more.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041116142410.GA48028>